Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parameter Capturing] Import external code for il rewriting #4389

Conversation

schmittjoseph
Copy link
Member

@schmittjoseph schmittjoseph commented May 10, 2023

Summary

Note: This is targeting a feature branch.

This PR imports code from the runtime repo relating to IL rewriting. Overview of commits:

  • The first commit only contains a direct import of external code with no modifications.
  • The second commit contains changes I've made to properly compile the new code and remove unnecessary code from ILRewriter.{cpp,.h} that won't be used.
  • Everything afterwards are changes made during the PR process.
Release Notes Entry

@schmittjoseph schmittjoseph requested a review from a team as a code owner May 10, 2023 17:43
@ghost ghost added the needs-review label May 10, 2023
@ghost ghost removed the needs-review label May 16, 2023
wiktork
wiktork previously approved these changes May 16, 2023
@ghost ghost removed the needs-review label May 16, 2023
@schmittjoseph schmittjoseph enabled auto-merge (squash) May 16, 2023 16:45
@schmittjoseph schmittjoseph merged commit 81a69f9 into dotnet:feature/parameter-capturing May 16, 2023
22 checks passed
@schmittjoseph schmittjoseph deleted the import-external-code branch May 16, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants