Use add_compiler_options to enable spectre mitigations and sdl checks #6658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
approved these changes
May 16, 2024
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/9117152280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
add_compiler_optionsto enable spectre mitigations and sdl checks. This helps pass the spectre mitigation flags to more of the vcxproj properties and SDL checks are enabled.Validation build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2452865&view=results
Release Notes Entry