Add --target-rid top level option #97
Conversation
Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>
| @@ -100,6 +102,10 @@ while [[ $# > 0 ]]; do | |||
| configuration=$2 | |||
| shift | |||
| ;; | |||
| -target-rid|-r) | |||
There was a problem hiding this comment.
| -target-rid|-r) | |
| -rid|-r) |
There was a problem hiding this comment.
I thought settled on --target-rid?
There was a problem hiding this comment.
I think target adds to the confusion of dotnet/source-build#4419.
For this top-level argument, imo we can just name it --rid.
There was a problem hiding this comment.
I would prefer target-rid here with a good documentation explaining that this really just determines the name and nothing else. I feel that consistency is more important here.
Btw should we add the switch to the Windows script as well?
And last but not least this PR needs to target the sdk repo.
There was a problem hiding this comment.
fwiw, I know target is meant to be similar as how gcc has a build, host and target platform.
In contrast to that, a target rid does not describe a target platform. It is just a name.
I think that difference is what causes the confusion in dotnet/source-build#4419.
There was a problem hiding this comment.
this PR needs to target the sdk repo.
@ViktorHofer how would that work? VMR build.sh is different than the one in SDK.
There was a problem hiding this comment.
https://github.com/dotnet/sdk/blob/main/src/SourceBuild/content/build.sh
We don't accept any PRs in this repository. This is just a mirror of code from various repos. Eventually the VMR will become its own source-of-truth but not until the beginning of .NET 10. See https://github.com/dotnet/dotnet?tab=readme-ov-file#contribution
There was a problem hiding this comment.
Ah, didn't knew it. Will close it.
We need this in case the user doesn't specify a rid. This is responsible to make non-portable builds use the rid calculated by |
|
Closing in favor of dotnet/sdk#41540. |
Closes dotnet/source-build#4413
cc @tmds