Migrations: Use invariant calendar for migration IDs

Fixes #12978
dotnet · Mar 18, 2019 · 1788681 · 1788681
1 parent a801679
commit 1788681
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/EFCore.Relational/Migrations/Internal/MigrationsIdGenerator.cs b/src/EFCore.Relational/Migrations/Internal/MigrationsIdGenerator.cs
@@ -62,7 +62,7 @@ public virtual string GenerateId(string name)
                 _lastTimestamp = timestamp;
             }
 
-            return timestamp.ToString(Format) + "_" + name;
+            return timestamp.ToString(Format, CultureInfo.InvariantCulture) + "_" + name;
         }
     }
 }
diff --git a/test/EFCore.Relational.Tests/Migrations/Internal/MigrationsIdGeneratorTest.cs b/test/EFCore.Relational.Tests/Migrations/Internal/MigrationsIdGeneratorTest.cs
@@ -1,6 +1,9 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System;
+using System.Globalization;
+using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
 using Xunit;
 
 namespace Microsoft.EntityFrameworkCore.Migrations.Internal
@@ -26,6 +29,17 @@ public void CreateId_always_increments_timestamp()
             Assert.NotEqual(id1, id2);
         }
 
+        [Fact]
+        [UseCulture("fa")]
+        public void CreateId_uses_invariant_calendar()
+        {
+            var invariantYear = CultureInfo.InvariantCulture.Calendar.GetYear(DateTime.Today).ToString();
+
+            var id = new MigrationsIdGenerator().GenerateId("Zecora");
+
+            Assert.StartsWith(invariantYear, id);
+        }
+
         [Fact]
         public void GetName_works()
         {