Query: Remove the requirement that instance or first argument would b…

…e enumerable in aggregate function (#28099) Feedback on #28092
dotnet · May 25, 2022 · 4cb70fd · 4cb70fd
1 parent 97783f5
commit 4cb70fd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs b/src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
@@ -943,8 +943,7 @@ protected override Expression VisitMethodCall(MethodCallExpression methodCallExp
                     {
                         var argument = arguments[i];
                         var visitedArgument = Visit(argument);
-                        if (i == 0
-                            && visitedArgument is EnumerableExpression)
+                        if (visitedArgument is EnumerableExpression)
                         {
                             if (enumerableExpression != null)
                             {

diff --git a/src/EFCore/Query/ICompiledQueryCacheKeyGenerator.cs b/src/EFCore/Query/ICompiledQueryCacheKeyGenerator.cs
@@ -5,12 +5,10 @@ namespace Microsoft.EntityFrameworkCore.Query;
 
 /// <summary>
 ///     <para>
-///         Creates keys that uniquely identifies a query. This is used to store and lookup
-///         compiled versions of a query in a cache.
+///         Creates keys that uniquely identifies a query. This is used to store and lookup compiled versions of a query in a cache.
 ///     </para>
 ///     <para>
-///         This type is typically used by database providers (and other extensions). It is generally
-///         not used in application code.
+///         This type is typically used by database providers (and other extensions). It is generally not used in application code.
 ///     </para>
 /// </summary>
 /// <remarks>