-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ILoggerFactory internal lifetime to scoped #14698
Labels
breaking-change
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
providers-beware
type-enhancement
Milestone
Comments
ajcvickers
added a commit
that referenced
this issue
Feb 14, 2019
Issue #14698 Main changes: * ILoggerFactory is still captured in AddDbContext, but as a wrapped scoped factory * Same thing can be done with UseLoggerFactory * No longer pathological to pass a different instance each time * IMemoryCache is no longer captured from AddDbContext * Can still be passed to UseMemoryCache * IRawSqlCommandBuilder and IMigrationsSqlGenerator have been made scoped * Validation and query compilation, method call translators, and a few more now accept the logger to use
ajcvickers
added a commit
that referenced
this issue
Feb 14, 2019
Issue #14698 Main changes: * ILoggerFactory is still captured in AddDbContext, but as a wrapped scoped factory * Same thing can be done with UseLoggerFactory * No longer pathological to pass a different instance each time * IMemoryCache is no longer captured from AddDbContext * Can still be passed to UseMemoryCache * IRawSqlCommandBuilder and IMigrationsSqlGenerator have been made scoped * Validation and query compilation, method call translators, and a few more now accept the logger to use
ajcvickers
added a commit
that referenced
this issue
Feb 15, 2019
Issue #14698 Main changes: * ILoggerFactory is still captured in AddDbContext, but as a wrapped scoped factory * Same thing can be done with UseLoggerFactory * No longer pathological to pass a different instance each time * IMemoryCache is no longer captured from AddDbContext * Can still be passed to UseMemoryCache * IRawSqlCommandBuilder and IMigrationsSqlGenerator have been made scoped * Validation and query compilation, method call translators, and a few more now accept the logger to use
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Mar 7, 2019
Also, ModificationCommandBatch now has a dependencies type See dotnet/efcore#14698
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Mar 7, 2019
Also, ModificationCommandBatch now has a dependencies type See dotnet/efcore#14698
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Mar 8, 2019
Also, ModificationCommandBatch now has a dependencies type See dotnet/efcore#14698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
providers-beware
type-enhancement
This has the following advantages:
UseLoggerFactory
with a new instance each time. This is currently a significant pit of failure that has consumed many victims.The disadvantages are:
The text was updated successfully, but these errors were encountered: