Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop calling AddLogging and AddMemoryCache in AddDbContext #14756

Closed
ajcvickers opened this issue Feb 20, 2019 · 3 comments
Closed

Stop calling AddLogging and AddMemoryCache in AddDbContext #14756

ajcvickers opened this issue Feb 20, 2019 · 3 comments
Assignees
@ajcvickers
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

Because EF no longer needs these services to be added to the application's service provider. However, any application that assumes AddDbContext adds these things will then break. This includes the ASP.NET Identity tests and MusicStore. It's not clear to me that the value of making this break is enough to justify doing it.
@smitpatel
Copy link
Member

Early break and get feedback?

@ajcvickers
Copy link
Member Author

@divega to follow up.

@ajcvickers ajcvickers mentioned this issue Mar 1, 2019
Closed
@ajcvickers
Copy link
Member Author

Related ASP.NET issue: dotnet/aspnetcore#7728

@ajcvickers ajcvickers self-assigned this Mar 4, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Mar 4, 2019
ajcvickers added a commit that referenced this issue Mar 10, 2019
@ajcvickers
Stop calling AddLogging and AddMemoryCache from AddDbContext
758a724 
Issue #14756

This will break some ASP.NET tests/samples when this change is consumed. (I tried to get ASP.NET tests to run locally with updated EF Core; no luck.)
@ajcvickers ajcvickers mentioned this issue Mar 10, 2019
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 10, 2019
ajcvickers added a commit that referenced this issue Mar 10, 2019
@ajcvickers
Stop calling AddLogging and AddMemoryCache from AddDbContext
a570a8d 
Issue #14756

This will break some ASP.NET tests/samples when this change is consumed. (I tried to get ASP.NET tests to run locally with updated EF Core; no luck.)
ajcvickers added a commit that referenced this issue Mar 11, 2019
@ajcvickers
Stop calling AddLogging and AddMemoryCache from AddDbContext
ab82cbe 
Issue #14756

This will break some ASP.NET tests/samples when this change is consumed. (I tried to get ASP.NET tests to run locally with updated EF Core; no luck.)
ajcvickers added a commit that referenced this issue Mar 11, 2019
@ajcvickers
Stop calling AddLogging and AddMemoryCache from AddDbContext
ae73b02 
Issue #14756

This will break some ASP.NET tests/samples when this change is consumed. (I tried to get ASP.NET tests to run locally with updated EF Core; no luck.)
ajcvickers added a commit to dotnet/aspnetcore that referenced this issue Mar 13, 2019
@ajcvickers
Add MemoryCache services where needed
f89505a 
Previously the tests were relying on EF adding the services. See dotnet/efcore#14756 and #7728
@ajcvickers ajcvickers mentioned this issue Mar 13, 2019
Merged
ajcvickers added a commit to dotnet/aspnetcore that referenced this issue Mar 13, 2019
@ajcvickers
Add MemoryCache services where needed
a8fd7f4 
Previously the tests were relying on EF adding the services. See dotnet/efcore#14756 and #7728
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview4 Apr 15, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview4, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajcvickers ajcvickers

Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel