Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor extension info/metadata from IDbContextOptionsExtension #16119

Closed
ajcvickers opened this issue Jun 16, 2019 · 0 comments · Fixed by #16118
Closed

Refactor extension info/metadata from IDbContextOptionsExtension #16119

ajcvickers opened this issue Jun 16, 2019 · 0 comments · Fixed by #16118
Assignees
@ajcvickers
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

Because we have now on multiple occasions needed to add to or change this interface. Breaking this out into an abstract base class that extensions can use will make it easier to evolve this without breaking extensions.

(Was part of #16045)
@ajcvickers ajcvickers added breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement labels Jun 16, 2019
@ajcvickers ajcvickers self-assigned this Jun 16, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 16, 2019
This was referenced Jun 16, 2019
Closed
Merged
ajcvickers added a commit that referenced this issue Jun 17, 2019
@ajcvickers
Break out metadata/info about an extension from the interface
96aa70b 
Also stop calling ApplyServices to find out if an extension is a database provider.

Fixes #16119
Fixes #16045

Doing this refactoring because we keep having to add/change methods here, so putting them in a composed abstract base class to avoid breaking the interface each time.
ajcvickers added a commit that referenced this issue Jun 17, 2019
@ajcvickers
Break out metadata/info about an extension from the interface
093026b 
Also stop calling ApplyServices to find out if an extension is a database provider.

Fixes #16119
Fixes #16045

Doing this refactoring because we keep having to add/change methods here, so putting them in a composed abstract base class to avoid breaking the interface each time.
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajcvickers ajcvickers

Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Break out metadata/info about an extension from the interface dotnet/efcore
1 participant
@ajcvickers