Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit model snapshots and the finalized model #17205

Closed
ajcvickers opened this issue Aug 16, 2019 · 0 comments · Fixed by #20305
Closed

Revisit model snapshots and the finalized model #17205

ajcvickers opened this issue Aug 16, 2019 · 0 comments · Fixed by #20305
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@ajcvickers
Copy link
Member

We have run into several issues (e.g. #17145) due to a disconnect between using a model snapshot (which is inherently built without conventions) and model finalization (which prevents use of the model until it has been finalized). We should revisit this area.
ajcvickers added a commit that referenced this issue Aug 16, 2019
@ajcvickers
Be more resilient when using the model from the model snapshot
ef1b09c 
Fixes #17145 but see also #17205

The fix here allows the state manager to work, which is required when the model snapshot has model data in it.
@ajcvickers ajcvickers mentioned this issue Aug 16, 2019
Merged
ajcvickers added a commit that referenced this issue Aug 17, 2019
@ajcvickers
Be more resilient when using the model from the model snapshot
7a87d96 
Fixes #17145 but see also #17205

The fix here allows the state manager to work, which is required when the model snapshot has model data in it.
ajcvickers added a commit that referenced this issue Aug 17, 2019
@ajcvickers
Be more resilient when using the model from the model snapshot
531a3be 
Fixes #17145 but see also #17205

The fix here allows the state manager to work, which is required when the model snapshot has model data in it.
ajcvickers added a commit that referenced this issue Aug 17, 2019
@ajcvickers
Be more resilient when using the model from the model snapshot
9f924e5 
Fixes #17145 but see also #17205

The fix here allows the state manager to work, which is required when the model snapshot has model data in it.
ajcvickers added a commit that referenced this issue Aug 17, 2019
@ajcvickers
Be more resilient when using the model from the model snapshot
50b9294 
Fixes #17145 but see also #17205

The fix here allows the state manager to work, which is required when the model snapshot has model data in it.
ajcvickers added a commit that referenced this issue Aug 17, 2019
@ajcvickers
Be more resilient when using the model from the model snapshot
d020b62 
Fixes #17145 but see also #17205

The fix here allows the state manager to work, which is required when the model snapshot has model data in it.
@ajcvickers ajcvickers added this to the Backlog milestone Aug 19, 2019
@AndriySvyryd AndriySvyryd self-assigned this Mar 20, 2020
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 5.0.0 Mar 20, 2020
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 20, 2020
@AndriySvyryd AndriySvyryd removed their assignment Mar 20, 2020
@AndriySvyryd AndriySvyryd linked a pull request Mar 20, 2020 that will close this issue
Refactor MigrationsModelDiffer to use the database model. #20305
Merged
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview3 Mar 31, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview3, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Refactor MigrationsModelDiffer to use the database model. dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd