Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the behavior of RequiredAttribute on navigations #17286

Closed
AndriySvyryd opened this issue Aug 20, 2019 · 1 comment · Fixed by #21701
Closed

Review the behavior of RequiredAttribute on navigations #17286

AndriySvyryd opened this issue Aug 20, 2019 · 1 comment · Fixed by #21701
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 20, 2019 •
edited
Loading

What should it do on the principal to dependent navigation? Consider #12100
Could it make sense on a collection navigation?
@AndriySvyryd AndriySvyryd mentioned this issue Aug 20, 2019
Merged
@ajcvickers ajcvickers added this to the Backlog milestone Aug 23, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 18, 2019
@lajones lajones assigned lajones and unassigned AndriySvyryd Apr 28, 2020
@lajones lajones removed the poachable label Apr 28, 2020
@lajones
Copy link
Contributor

lajones commented Apr 28, 2020

Poaching

@ajcvickers ajcvickers assigned AndriySvyryd and unassigned lajones Jul 17, 2020
AndriySvyryd added a commit that referenced this issue Jul 20, 2020
@AndriySvyryd
Log an error for Required on principal to dependent
8e2832a 
Fixes #17286
This was referenced Jul 20, 2020
Merged
Closed
@AndriySvyryd AndriySvyryd removed their assignment Jul 20, 2020
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 20, 2020
@ghost ghost closed this as completed in #21701 Jul 20, 2020
ghost pushed a commit that referenced this issue Jul 20, 2020
@AndriySvyryd
Log an error for Required on principal to dependent (#21701)
9b8fed6 
* Log an error for Required on principal to dependent

Fixes #17286

* Obsolete LogRequiredAttributeInverted and LogNonNullableInverted
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Log an error for Required on principal to dependent dotnet/efcore
3 participants
@ajcvickers @lajones @AndriySvyryd