Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Don't use a discriminator for embedded entities without inheritance #17302

Closed
AndriySvyryd opened this issue Aug 20, 2019 · 0 comments · Fixed by #17876
Closed

Cosmos: Don't use a discriminator for embedded entities without inheritance #17302

AndriySvyryd opened this issue Aug 20, 2019 · 0 comments · Fixed by #17876
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.1.0

Comments

@AndriySvyryd
Copy link
Member

No description provided.

@smitpatel smitpatel mentioned this issue Aug 20, 2019
Closed
82 tasks
@ajcvickers ajcvickers added this to the Backlog milestone Aug 26, 2019
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 3.1.0 Sep 11, 2019
@AndriySvyryd AndriySvyryd self-assigned this Sep 11, 2019
AndriySvyryd added a commit that referenced this issue Sep 17, 2019
@AndriySvyryd
Don't add discriminators for embedded entities
f44ba0d 
Allow to update entities without discriminators
Don't try to add the default discriminator if a conflicting property already exists

Fixes #17764
Fixes #17302
Fixes #17814
@AndriySvyryd AndriySvyryd mentioned this issue Sep 17, 2019
Merged
@AndriySvyryd AndriySvyryd added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed consider-for-current-release labels Sep 17, 2019
@AndriySvyryd AndriySvyryd removed their assignment Sep 17, 2019
AndriySvyryd added a commit that referenced this issue Sep 17, 2019
@AndriySvyryd
Don't add discriminators for embedded entities
550939c 
Allow to update entities without discriminators
Don't try to add the default discriminator if a conflicting property already exists

Fixes #17764
Fixes #17302
Fixes #17814
AndriySvyryd added a commit that referenced this issue Sep 17, 2019
@AndriySvyryd
Don't add discriminators for embedded entities
1e9110d 
Allow to update entities without discriminators
Don't try to add the default discriminator if a conflicting property already exists

Fixes #17764
Fixes #17302
Fixes #17814
AndriySvyryd added a commit that referenced this issue Sep 17, 2019
@AndriySvyryd
Don't add discriminators for embedded entities
460e347 
Allow to update entities without discriminators
Don't try to add the default discriminator if a conflicting property already exists

Fixes #17764
Fixes #17302
Fixes #17814
AndriySvyryd added a commit that referenced this issue Sep 17, 2019
@AndriySvyryd
Don't add discriminators for embedded entities
718700c 
Allow to update entities without discriminators
Don't try to add the default discriminator if a conflicting property already exists

Fixes #17764
Fixes #17302
Fixes #17814
@ajcvickers ajcvickers modified the milestones: 3.1.0, 3.1.0-preview1 Oct 15, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0-preview1, 3.1.0 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Fix some Cosmos discriminator issues dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd