Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert metadata extension methods to default interface implementations. #19213

Closed
4 tasks done
AndriySvyryd opened this issue Dec 6, 2019 · 0 comments · Fixed by #24205
Closed
4 tasks done

Convert metadata extension methods to default interface implementations. #19213

AndriySvyryd opened this issue Dec 6, 2019 · 0 comments · Fixed by #24205
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Dec 6, 2019 •
edited
Loading

This allows more efficient implementations of these methods and is required for other IModel implementations: #1906 and #8258.

  • Convert IModel extension methods
  • Convert IRelationalModel extension methods
  • Add IReadOnly interfaces for non-runtime Metadata.
  • Move ConstructorBinding to IEntityType.

For more context see #5074
@ajcvickers ajcvickers added this to the Backlog milestone Dec 9, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Dec 16, 2019
Closed
24 tasks
@AndriySvyryd AndriySvyryd mentioned this issue Jan 30, 2020
Closed
@AndriySvyryd AndriySvyryd mentioned this issue Aug 12, 2020
Closed
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 2, 2020
@ajcvickers ajcvickers removed their assignment Nov 2, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Nov 17, 2020
Merged
AndriySvyryd added a commit that referenced this issue Jan 29, 2021
@AndriySvyryd
Add a new set of interfaces to hide runtime members during model buil…
a549567 
…ding

Part of #19213
@AndriySvyryd AndriySvyryd mentioned this issue Jan 29, 2021
Merged
AndriySvyryd added a commit that referenced this issue Jan 29, 2021
@AndriySvyryd
Add a new set of interfaces to hide runtime members during model buil…
e8d9e62 
…ding

Part of #19213
AndriySvyryd added a commit that referenced this issue Jan 29, 2021
@AndriySvyryd
Add a new set of interfaces to hide runtime members during model buil…
2c72d43 
…ding

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 1, 2021
@AndriySvyryd
Add a new set of interfaces to hide runtime members during model buil…
c654378 
…ding

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 1, 2021
@AndriySvyryd
Add a new set of interfaces to hide runtime members during model buil…
1e09225 
…ding

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 1, 2021
@AndriySvyryd
Add a new set of interfaces to hide runtime members during model buil…
1e8f1f6 
…ding

Part of #19213
ghost pushed a commit that referenced this issue Feb 1, 2021
@AndriySvyryd
Add a new set of interfaces to hide runtime members during model buil…
9a8c6c7 
…ding (#24017)

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 3, 2021
@AndriySvyryd
Move ConstructionBinding from an annotation to an interface
ebd4a18 
Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 3, 2021
@AndriySvyryd
Move ConstructionBinding from an annotation to an interface
9bed061 
Part of #19213
@AndriySvyryd AndriySvyryd mentioned this issue Feb 3, 2021
Merged
AndriySvyryd added a commit that referenced this issue Feb 3, 2021
@AndriySvyryd
Move ConstructionBinding from an annotation to an interface
64293d7 
Move OnModelFinalized invocation to ModelRuntimeInitializer

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 3, 2021
@AndriySvyryd
Move ConstructionBinding from an annotation to an interface
4141299 
Move OnModelFinalized invocation to ModelRuntimeInitializer

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 5, 2021
@AndriySvyryd
Move ConstructionBinding from an annotation to an interface
a1e37a6 
Move OnModelFinalized invocation to ModelRuntimeInitializer

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 8, 2021
@AndriySvyryd
Move IReadOnlyAnnotatable and IReadOnlyModel extension methods to the…
40f54ea 
… interfaces

Part of #19213
@AndriySvyryd AndriySvyryd mentioned this issue Feb 8, 2021
Merged
AndriySvyryd added a commit that referenced this issue Feb 11, 2021
@AndriySvyryd
Move IReadOnlyTypeBase and IReadOnlyEntityType extension methods to t…
e401e9d 
…he interfaces

Introduce IInternalEntityType

Part of #19213
@AndriySvyryd AndriySvyryd mentioned this issue Feb 11, 2021
Merged
AndriySvyryd added a commit that referenced this issue Feb 12, 2021
@AndriySvyryd
Move IReadOnlyTypeBase and IReadOnlyEntityType extension methods to t…
d1d3efb 
…he interfaces (#24131)

Introduce IInternalEntityType

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 12, 2021
@AndriySvyryd
Move IReadOnlyAnnotatable and IReadOnlyModel extension methods to the…
d6bcb1f 
… interfaces

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 12, 2021
@AndriySvyryd
Move IReadOnlyAnnotatable and IReadOnlyModel extension methods to the…
b708390 
… interfaces

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 18, 2021
@AndriySvyryd
Move IProperty and IPropertyBase extension methods to the interfaces
662b996 
Rename GetDiscriminatorProperty to FindDiscriminatorProperty

Part of #19213
@AndriySvyryd AndriySvyryd mentioned this issue Feb 18, 2021
Merged
AndriySvyryd added a commit that referenced this issue Feb 18, 2021
@AndriySvyryd
Move IProperty and IPropertyBase extension methods to the interfaces
74ddd03 
Rename GetDiscriminatorProperty to FindDiscriminatorProperty

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 18, 2021
@AndriySvyryd
Move IProperty and IPropertyBase extension methods to the interfaces
5e76851 
Rename GetDiscriminatorProperty to FindDiscriminatorProperty

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 18, 2021
@AndriySvyryd
Move IIndex, INavigation and related extension methods to the interfaces
e017a45 
Part of #19213
@AndriySvyryd AndriySvyryd mentioned this issue Feb 18, 2021
Merged
AndriySvyryd added a commit that referenced this issue Feb 19, 2021
@AndriySvyryd
Move IIndex, INavigation and related extension methods to the interfaces
9c7717a 
Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 19, 2021
@AndriySvyryd
Move IKey and IForeignKey extension methods to the interfaces
3945b32 
Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 19, 2021
@AndriySvyryd
Move IIndex, IKey, IForeignKey, INavigation and related extension met…
4b46d50 
…hods to the interfaces

Part of #19213
AndriySvyryd added a commit that referenced this issue Feb 20, 2021
@AndriySvyryd
Move IRelationalModel extension methods to the interfaces
ab624d2 
Rename SingletonModelDependencies to RuntimeModelDependencies
Rename GetEntityTypes(Type) to FindEntityTypes(Type)
Rename FindPrincipals() to GetPrincipals()
Remove IModelCreationDependencies

Fixes #19213
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 20, 2021
@AndriySvyryd AndriySvyryd removed their assignment Feb 20, 2021
AndriySvyryd added a commit that referenced this issue Feb 20, 2021
@AndriySvyryd
Move IRelationalModel extension methods to the interfaces
4b60e6f 
Rename SingletonModelDependencies to RuntimeModelDependencies
Rename GetEntityTypes(Type) to FindEntityTypes(Type)
Rename FindPrincipals() to GetPrincipals()
Remove IModelCreationDependencies

Fixes #19213
@AndriySvyryd AndriySvyryd mentioned this issue Feb 20, 2021
Merged
AndriySvyryd added a commit that referenced this issue Feb 20, 2021
@AndriySvyryd
Move IRelationalModel extension methods to the interfaces
9b577a4 
Rename SingletonModelDependencies to RuntimeModelDependencies
Rename GetEntityTypes(Type) to FindEntityTypes(Type)
Rename FindPrincipals() to GetPrincipals()
Remove IModelCreationDependencies

Fixes #19213
AndriySvyryd added a commit that referenced this issue Feb 22, 2021
@AndriySvyryd
Move IRelationalModel extension methods to the interfaces
04bdaa3 
Rename SingletonModelDependencies to RuntimeModelDependencies
Rename GetEntityTypes(Type) to FindEntityTypes(Type)
Rename FindPrincipals() to GetPrincipals()
Remove IModelCreationDependencies

Fixes #19213
AndriySvyryd added a commit that referenced this issue Feb 23, 2021
@AndriySvyryd
Move IRelationalModel extension methods to the interfaces
126ffde 
Rename SingletonModelDependencies to RuntimeModelDependencies
Rename GetEntityTypes(Type) to FindEntityTypes(Type)
Rename FindPrincipals() to GetPrincipals()
Remove IModelCreationDependencies

Fixes #19213
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview3 Mar 5, 2021
@AndriySvyryd AndriySvyryd mentioned this issue Oct 5, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview3, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Move IRelationalModel extension methods to the interfaces dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd