Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForeignKeys, Keys and Indexes on Property should have a strong order defined #19361

Closed
AndriySvyryd opened this issue Dec 19, 2019 · 2 comments · Fixed by #32124
Closed

ForeignKeys, Keys and Indexes on Property should have a strong order defined #19361

AndriySvyryd opened this issue Dec 19, 2019 · 2 comments · Fixed by #32124
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-5.0 punted-for-6.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-bug
Milestone
9.0.0-preview1

Comments

@AndriySvyryd
Copy link
Member

No description provided.

@ajcvickers
Copy link
Member

@AndriySvyryd I can think of a few reasons why this might be. What are you thinking of?

@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented Dec 19, 2019 •
edited

All metadata collections should have a strong order to ensure that model building output isn't dependent on configuration/discovery order.

@ajcvickers ajcvickers added this to the 5.0.0 milestone Dec 23, 2019
@ajcvickers ajcvickers modified the milestones: 5.0.0, Backlog Jul 20, 2020
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, MQ Sep 4, 2020
@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Dec 16, 2020
@ajcvickers ajcvickers modified the milestones: 6.0.0, Backlog Sep 24, 2021
@ajcvickers ajcvickers modified the milestones: Backlog, 7.0.0 Nov 10, 2021
@ajcvickers ajcvickers added propose-punt punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. and removed propose-punt labels Jul 6, 2022
@ajcvickers ajcvickers removed this from the 7.0.0 milestone Jul 7, 2022
@ajcvickers ajcvickers added this to the Backlog milestone Jul 7, 2022
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, MQ Oct 21, 2023
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 22, 2023
@AndriySvyryd AndriySvyryd removed their assignment Oct 22, 2023
AndriySvyryd added a commit that referenced this issue Oct 22, 2023
@AndriySvyryd
Use OrderedDictionary or Dictionary instead of SortedDictionary in Ru…
d6b3678 
…ntimeModel

Fixes #31142
Fixes #19361
AndriySvyryd added a commit that referenced this issue Oct 22, 2023
@AndriySvyryd
Use OrderedDictionary or Dictionary instead of SortedDictionary in Ru…
7d53c7d 
…ntimeModel

Fixes #31142
Fixes #19361
@AndriySvyryd AndriySvyryd mentioned this issue Oct 22, 2023
Merged
AndriySvyryd added a commit that referenced this issue Oct 24, 2023
@AndriySvyryd
Use OrderedDictionary or Dictionary instead of SortedDictionary in Ru…
d8e9f61 
…ntimeModel (#32124)

Fixes #31142
Fixes #19361
@ajcvickers ajcvickers modified the milestones: MQ, Backlog, 9.0.0 Nov 14, 2023
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-5.0 punted-for-6.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-bug
Projects
None yet
Milestone
9.0.0-preview1
Development

Successfully merging a pull request may close this issue.

Use OrderedDictionary or Dictionary instead of SortedDictionary in RuntimeModel dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd