Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks: remove Sqlite from benchmark name #19874

Open
Tracked by #22588
roji opened this issue Feb 11, 2020 · 3 comments
Open
Tracked by #22588

Benchmarks: remove Sqlite from benchmark name #19874

roji opened this issue Feb 11, 2020 · 3 comments
Assignees
@roji
Labels
area-benchmarks area-perf blocked punted-for-5.0 type-cleanup
Milestone
MQ

Comments

@roji
Copy link
Member

roji commented Feb 11, 2020

On our benchmark dashboard, some category names are clean (e.g. Mixed, Insert) while some have Sqlite in them, although the whole thing is already nested under a Sqlite node. Clean that up.

Probably requires a database cleanup as well at the same time, can do this on my next visit to Redmond.

/cc @sebastienros
@roji roji self-assigned this Feb 11, 2020
@roji roji changed the title Benchmarks: remove Sqlite/SqlServer from benchmark name Benchmarks: remove Sqlite from benchmark name Feb 11, 2020
@roji roji added the area-perf label Feb 11, 2020
@ajcvickers ajcvickers added this to the 5.0.0 milestone Feb 14, 2020
@roji
Copy link
Member Author

roji commented May 2, 2020 •
edited

Blocked on dotnet/BenchmarkDotNet#1447

@roji roji added the blocked label May 2, 2020
@roji roji modified the milestones: 5.0.0, Backlog May 2, 2020
@roji roji removed the blocked label May 2, 2020
@roji roji modified the milestones: Backlog, 5.0.0 May 2, 2020
roji added a commit that referenced this issue May 2, 2020
@roji
Benchmarks: cleanup benchmark class names
290362c 
Mainly to remove the database name

Closes #19874
roji added a commit to roji/efcore that referenced this issue May 2, 2020
@roji
Benchmarks: cleanup benchmark class names
b966e2d 
Mainly to remove the database name

Closes dotnet#19874
roji added a commit that referenced this issue May 2, 2020
@roji
Benchmarks: cleanup benchmark class names
cf40b08 
Mainly to remove the database name

Closes #19874
@roji roji removed this from the 5.0.0 milestone Jul 20, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Jul 24, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@ajcvickers
Copy link
Member

Part of #22588

@ajcvickers ajcvickers mentioned this issue Sep 17, 2020
Open
6 tasks
@roji roji linked a pull request Jul 29, 2021 that will close this issue
Benchmark cleanup #20821
Closed
@roji
Copy link
Member Author

roji commented Jul 29, 2021

Attempted in #20821 but never merged, bring that PR back.

@roji roji mentioned this issue Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-benchmarks area-perf blocked punted-for-5.0 type-cleanup
Projects
None yet
Milestone
MQ
Development

Successfully merging a pull request may close this issue.

Benchmark cleanup dotnet/efcore
2 participants
@ajcvickers @roji