Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Remove EF.Functions.Like from InMemory provider #20293

Closed
smitpatel opened this issue Mar 15, 2020 · 2 comments · Fixed by #20311
Closed

Query: Remove EF.Functions.Like from InMemory provider #20293

smitpatel opened this issue Mar 15, 2020 · 2 comments · Fixed by #20311
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

InMemory does not support it. The implementation differs on database provider used. There is no correct InMemory behavior. We should remove it and move the method to relational layer with client eval throw.
@ajcvickers
Copy link
Member

@smitpatel Does it currently work when used with the in-memory provider?

@ajcvickers
Copy link
Member

Specific case of #20294 where we need to preserve the in-memory behavior.

@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 16, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 17, 2020
smitpatel added a commit that referenced this issue Mar 17, 2020
@smitpatel
Query: Remove client implementation for EF.Functions.Like
62531f8 
InMemory translates it using an provider specific method now

Resolves #20293
@smitpatel smitpatel mentioned this issue Mar 17, 2020
Merged
smitpatel added a commit that referenced this issue Mar 17, 2020
@smitpatel
Query: Remove client implementation for EF.Functions.Like
47d1ebe 
InMemory translates it using an provider specific method now

Resolves #20293
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview3 Mar 31, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview3, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Remove client implementation for EF.Functions.Like dotnet/efcore
2 participants
@ajcvickers @smitpatel