Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Lift table from subquery when joining if no additional operations #21321

Closed
Tracked by #18923
smitpatel opened this issue Jun 18, 2020 · 1 comment
Closed
Tracked by #18923
Assignees
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@smitpatel
Copy link
Member

When doing join, we pushdown the right SelectExpression if it has various operations applied to SelectExpression in order to apply them before join. One of them is existence of order by clause. But we also remove order by from subquery when there is no skip take as that ordering is irrelevant and lifted outside already. This causes a query to be pushed down but then erases order by so we have a flat select expression with projection and single table. We could avoid pushdown and generate flat join table.

@smitpatel
Copy link
Member Author

Fixed by #26476

@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 19, 2021
@smitpatel smitpatel modified the milestones: Backlog, 7.0.0 Nov 19, 2021
@smitpatel smitpatel self-assigned this Nov 19, 2021
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants