Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigationBuilder does not have HasField overload taking FieldInfo #21539

Closed
smitpatel opened this issue Jul 7, 2020 · 0 comments · Fixed by #21550
Closed

NavigationBuilder does not have HasField overload taking FieldInfo #21539

smitpatel opened this issue Jul 7, 2020 · 0 comments · Fixed by #21550
Assignees
@smitpatel
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

smitpatel commented Jul 7, 2020 •
edited by AndriySvyryd

Also remove HasField/UserPropertyAccessMode/IsEagerLoaded from IConventionFKBuilder.
@smitpatel smitpatel self-assigned this Jul 7, 2020
@smitpatel smitpatel added this to the 5.0.0 milestone Jul 7, 2020
smitpatel added a commit that referenced this issue Jul 7, 2020
@smitpatel
Metadata: Add HasField(FieldInfo) on NavigationBuilder
ab85439 
- Cleanup some of the methods in internal builders

Resolves #21539
@smitpatel smitpatel mentioned this issue Jul 7, 2020
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 7, 2020
@ghost ghost closed this as completed in #21550 Jul 7, 2020
ghost pushed a commit that referenced this issue Jul 7, 2020
@smitpatel
Metadata: Add HasField(FieldInfo) on NavigationBuilder (#21550)
12ebbdb 
- Cleanup some of the methods in internal builders

Resolves #21539
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview8 Jul 14, 2020
@ajcvickers ajcvickers mentioned this issue Aug 27, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Metadata: Add HasField(FieldInfo) on NavigationBuilder dotnet/efcore
2 participants
@ajcvickers @smitpatel