Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Data.Sqlite: Add Default Timeout connection string keyword #22505

Closed
Tracked by #22949
bricelam opened this issue Sep 11, 2020 · 3 comments · Fixed by #23091
Closed
Tracked by #22949

Microsoft.Data.Sqlite: Add Default Timeout connection string keyword #22505

bricelam opened this issue Sep 11, 2020 · 3 comments · Fixed by #23091
Assignees
@bricelam
Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone
6.0.0

Comments

@bricelam
Copy link
Contributor

We should add the Default Timeout connection string keyword. Order of precedence would be:

  1. SqliteCommand.CommandTimeout (always wins if set)
  2. SqliteConnection.DefaultTimeout
  3. Default Time= in the connection string
  4. 30 (the ADO.NET default)
@bricelam bricelam self-assigned this Sep 11, 2020
@bricelam bricelam mentioned this issue Sep 11, 2020
Closed
@bricelam
Copy link
Contributor Author

Note to implementor: make sure Command Timeout is also valid since that seems to be the de facto standard.

@roji
Copy link
Member

roji commented Sep 12, 2020

Yeah, Command Timeout is what everyone does. Note that I'm not aware of others providing DbConnection.DefaultTimeout, but that's not a reason not to do it.

@ajcvickers ajcvickers added this to the Backlog milestone Sep 14, 2020
@ajcvickers ajcvickers mentioned this issue Oct 10, 2020
Open
16 tasks
nmichels pushed a commit to nmichels/EntityFrameworkCore that referenced this issue Oct 24, 2020
Microsoft.Data.Sqlite: Add Default Timeout connection string keyword
0cbb867 
- Fixes dotnet#22505
@nmichels nmichels mentioned this issue Oct 24, 2020
Merged
@nmichels
Copy link
Contributor

Hi there! I'm trying to implement a solution for that Issue, PR attached. Please let me know if the approach is right. Thanks in advance!

@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 4, 2020
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 8, 2020
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Microsoft.Data.Sqlite: Add Default Timeout connection string keyword nmichels/EntityFrameworkCore
4 participants
@bricelam @ajcvickers @roji @nmichels