Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasSchema(null) does not override DbFunction attribute #24228

Closed
cincuranet opened this issue Feb 23, 2021 · 2 comments · Fixed by #25031
Closed

HasSchema(null) does not override DbFunction attribute #24228

cincuranet opened this issue Feb 23, 2021 · 2 comments · Fixed by #25031
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone
6.0.0

Comments

@cincuranet
Copy link
Contributor

Having DbFunction(Schema = "foo") and later using HasSchema(null) does not remove the schema from the model. Using HasSchema("bar") works fine.

EF Core version: 5.0.3
@roji
Copy link
Member

roji commented Feb 23, 2021

Seems like this is because we reset the configuration source to null when the schema is explicitly set to null (another one of these philosophical null questions :)).

@ajcvickers ajcvickers added this to the 6.0.0 milestone Feb 23, 2021
@ajcvickers
Copy link
Member

Note from triage: we will change the behavior here to remove the set schema when null is used.

AndriySvyryd added a commit that referenced this issue Jun 3, 2021
@AndriySvyryd
Make DbFunction.HasSchema(null) always override the attribute
b11974c 
Fixes #24228
@AndriySvyryd AndriySvyryd removed their assignment Jun 3, 2021
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 3, 2021
@AndriySvyryd AndriySvyryd mentioned this issue Jun 3, 2021
Merged
AndriySvyryd added a commit that referenced this issue Jun 3, 2021
@AndriySvyryd
Make DbFunction.HasSchema(null) always override the attribute
b141038 
Fixes #24228
@AndriySvyryd AndriySvyryd modified the milestones: 6.0.0, 6.0.0-preview6 Jul 2, 2021
@ajcvickers ajcvickers mentioned this issue Jul 29, 2021
Closed
@ajcvickers ajcvickers mentioned this issue Oct 17, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview6, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Make DbFunction.HasSchema(null) always override the attribute dotnet/efcore
4 participants
@ajcvickers @roji @cincuranet @AndriySvyryd