Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set provider value comparer when configuring value conversion #27738

Closed
AndriySvyryd opened this issue Apr 1, 2022 · 0 comments · Fixed by #27942
Closed

Allow to set provider value comparer when configuring value conversion #27738

AndriySvyryd opened this issue Apr 1, 2022 · 0 comments · Fixed by #27942
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression type-enhancement
Milestone
7.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Apr 1, 2022 •
edited
Loading

This would allow to use case-insensitive comparison for example.

Consider showing a warning when an FK or PK property has a custom value comparer but provider value comparer is not specified
@AndriySvyryd AndriySvyryd added this to the 7.0.0 milestone Apr 1, 2022
@AndriySvyryd AndriySvyryd self-assigned this Apr 1, 2022
@AndriySvyryd AndriySvyryd mentioned this issue Apr 4, 2022
Merged
@AndriySvyryd AndriySvyryd mentioned this issue Apr 6, 2022
Closed
@AndriySvyryd AndriySvyryd removed their assignment May 3, 2022
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 3, 2022
AndriySvyryd added a commit that referenced this issue May 3, 2022
@AndriySvyryd
Allow to configure provider value comparer
9a7e792 
Fixes #27738
AndriySvyryd added a commit that referenced this issue May 3, 2022
@AndriySvyryd
Allow to set provider value comparer when configuring value conversion
a61d598 
Use client value comparer as provider value comparer if possible
The client value comparer will not be used if the model type is a nullable value type
Fix some API issues
Remove some unused code

Fixes #27738
Fixes #27850
Fixes #27791
Part of #27588
AndriySvyryd added a commit that referenced this issue May 3, 2022
@AndriySvyryd
Allow to set provider value comparer when configuring value conversion
1ec8f89 
Use client value comparer as provider value comparer if possible
The client value comparer will not be used if the model type is a nullable value type
Fix some API issues
Remove some unused code

Fixes #27738
Fixes #27850
Fixes #27791
Part of #27588
@AndriySvyryd AndriySvyryd mentioned this issue May 3, 2022
Merged
AndriySvyryd added a commit that referenced this issue May 5, 2022
@AndriySvyryd
Allow to set provider value comparer when configuring value conversion
3ea4803 
Use client value comparer as provider value comparer if possible
    The client value comparer will not be used if the model type is a nullable value type since we need the types to match exactly and the provider type is never nullable
Fix some API issues
Remove some unused code

Fixes #27738
Fixes #27850
Fixes #27791
Part of #27588
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview5 May 25, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview5, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression type-enhancement
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Allow to set provider value comparer when configuring value conversion dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd