Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make existing model building conventions more extensible #28866

Closed
Tracked by #22952
ajcvickers opened this issue Aug 24, 2022 · 0 comments · Fixed by #32193
Closed
Tracked by #22952

Make existing model building conventions more extensible #28866

ajcvickers opened this issue Aug 24, 2022 · 0 comments · Fixed by #32193
Labels
area-conventions area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. needs-design type-enhancement
Milestone
9.0.0-preview1

Comments

@ajcvickers
Copy link
Member

I have been attempting to create my own PropertyDiscoveryConvention, but it's difficult without copying almost all of the existing code in the convention, and creating my own helpers (#28854). Things would be easier in this and other cases if existing convention classes:

  • Made appropriate private methods protected
  • Split some of these methods up to allow more granular overrides
  • Added pure template methods in useful places
@ajcvickers ajcvickers added this to the Backlog milestone Aug 30, 2022
@AndriySvyryd AndriySvyryd self-assigned this Oct 19, 2022
@AndriySvyryd AndriySvyryd mentioned this issue Oct 19, 2022
Open
73 tasks
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, MQ Oct 28, 2023
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 28, 2023
@AndriySvyryd AndriySvyryd removed their assignment Oct 28, 2023
AndriySvyryd added a commit that referenced this issue Oct 31, 2023
@AndriySvyryd
Make existing model building conventions more extensible
513ab10 
Allow to ignore attributes when finding type mapping

Fixes #11124
Fixes #28866
@AndriySvyryd AndriySvyryd mentioned this issue Oct 31, 2023
Merged
AndriySvyryd added a commit that referenced this issue Oct 31, 2023
@AndriySvyryd
Make existing model building conventions more extensible
2b0b576 
Allow to ignore attributes when finding type mapping

Fixes #11124
Fixes #28866
AndriySvyryd added a commit that referenced this issue Nov 2, 2023
@AndriySvyryd
Allow to ignore attributes when finding type mapping (#32193)
60915e7 
Make existing model building conventions more extensible

Fixes #11124
Fixes #28866
@ajcvickers ajcvickers modified the milestones: MQ, Backlog, 9.0.0 Nov 14, 2023
AndriySvyryd added a commit that referenced this issue Dec 19, 2023
@AndriySvyryd
Break up KeyDiscoveryConvention
ffd97cd 
Part of #28866
@AndriySvyryd AndriySvyryd mentioned this issue Dec 19, 2023
Merged
AndriySvyryd added a commit that referenced this issue Dec 19, 2023
@AndriySvyryd
Break up KeyDiscoveryConvention
75248be 
Part of #28866
AndriySvyryd added a commit that referenced this issue Dec 20, 2023
@AndriySvyryd
Break up KeyDiscoveryConvention
0679cf3 
Derive JsonTypesTestBase from NonSharedModelTestBase

Part of #28866
AndriySvyryd added a commit that referenced this issue Jan 4, 2024
@AndriySvyryd
Break up KeyDiscoveryConvention
80493be 
Derive JsonTypesTestBase from NonSharedModelTestBase

Part of #28866
AndriySvyryd added a commit that referenced this issue Jan 4, 2024
@AndriySvyryd
Break up KeyDiscoveryConvention (#32650)
2fb3cf2 
Derive JsonTypesTestBase from NonSharedModelTestBase

Part of #28866
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-conventions area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. needs-design type-enhancement
Projects
None yet
Milestone
9.0.0-preview1
Development

Successfully merging a pull request may close this issue.

Allow to ignore attributes when finding type mapping dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd