Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WarningsConfiguration is not propagated correctly in SQL Server provider #29069

Closed
ajcvickers opened this issue Sep 13, 2022 · 0 comments · Fixed by #29086
Closed

WarningsConfiguration is not propagated correctly in SQL Server provider #29069

ajcvickers opened this issue Sep 13, 2022 · 0 comments · Fixed by #29086
Assignees
@ajcvickers
Labels
area-logging breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
7.0.0

Comments

@ajcvickers
Copy link
Member

Relational warnings configuration is lost when applying SQL Server-specific warnings.

        coreOptionsExtension = RelationalOptionsExtension.WithDefaultWarningConfiguration(coreOptionsExtension)
            .WithWarningsConfiguration(
                coreOptionsExtension.WarningsConfiguration.TryWithExplicit(
                    SqlServerEventId.ConflictingValueGenerationStrategiesWarning, WarningBehavior.Throw));

Notice that the result of WithDefaultWarningConfiguration is not used to call coreOptionsExtension.WarningsConfiguration.TryWithExplicit.
@ajcvickers ajcvickers self-assigned this Sep 13, 2022
ajcvickers added a commit that referenced this issue Sep 14, 2022
@ajcvickers
Ensure warnings configured to throw really do throw with the SQL Serv…
3245e3b 
…er provider

Fixes #29069
This was referenced Sep 14, 2022
Merged
Closed
@ajcvickers ajcvickers reopened this Sep 14, 2022
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 16, 2022
@ajcvickers ajcvickers added this to the 7.0.0-rc2 milestone Sep 16, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-rc2, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajcvickers ajcvickers

Labels
area-logging breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Ensure warnings configured to throw really do throw with the SQL Server provider dotnet/efcore
1 participant
@ajcvickers