Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generated class members to have same name as generated classes when casing differs #30237

Closed
ErikEJ opened this issue Feb 9, 2023 · 1 comment · Fixed by #32629
Closed
Assignees
Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug

Comments

@ErikEJ
Copy link
Contributor

ErikEJ commented Feb 9, 2023

When reverse engineering this table:

CREATE TABLE [dbo].[UIText]
(
	[UiKey] VARCHAR(100) NOT NULL PRIMARY KEY,
	[UiText] NVARCHAR(1000) NOT NULL
)

The UiText is generated with a "1" suffix, despite it not matching the containg class name (case sensitive) - regardless of whether "Use database names" is chosen.

public partial class Uitext
{
    public string UiKey { get; set; }

    public string UiText1 { get; set; }
}

Happens for both EF Core 6 and 7

see ErikEJ/EFCorePowerTools#1684

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Aug 1, 2023

Looks like this was introduced to fix this: #9257

ajcvickers added a commit that referenced this issue Dec 16, 2023
ajcvickers added a commit that referenced this issue Dec 20, 2023
@ajcvickers ajcvickers self-assigned this Dec 20, 2023
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 20, 2023
@ajcvickers ajcvickers modified the milestones: Backlog, 9.0.0 Dec 20, 2023
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
2 participants