Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC2 IEntityType changes break libraries like MassTransit #32105

Closed
molinch opened this issue Oct 20, 2023 · 1 comment
Closed

RC2 IEntityType changes break libraries like MassTransit #32105

molinch opened this issue Oct 20, 2023 · 1 comment
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-bug
Milestone
8.0.0

Comments

@molinch
Copy link

molinch commented Oct 20, 2023 •
edited

The recent changes to IEntityType for EF8 rc2: 5ef57c1#diff-f03977044a0b9cf7ad3988e40c4780d300a7984b4db007861b86a66503f29308 removed the IEntityType.GetProperties that was hiding the one from the base method, see:
image

Unfortunately that breaks the usage done in popular libraries like MassTransit. They use it like: https://github.com/MassTransit/MassTransit/blob/develop/src/Persistence/MassTransit.EntityFrameworkCoreIntegration/EntityFrameworkCoreIntegration/SqlLockStatementProvider.cs#L88C47-L88C47
image

This means that EF8 rc2 is not compatible at IL level with existing libs if they use any of the removed IEntityType properties.
Is there a way to bring it back, or you would say it's up to the libraries to change their code?

EF Core version: EF8 rc2
@molinch molinch mentioned this issue Oct 20, 2023
Closed
@ajcvickers
Copy link
Member

/cc @AndriySvyryd

@AndriySvyryd AndriySvyryd added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-consider breaking-change labels Oct 26, 2023
AndriySvyryd added a commit that referenced this issue Oct 26, 2023
@AndriySvyryd
Revert binary breaking change on IEntityType
6305f41 
Fixes #32105
@AndriySvyryd AndriySvyryd mentioned this issue Oct 26, 2023
Merged
AndriySvyryd added a commit that referenced this issue Oct 26, 2023
@AndriySvyryd
Revert binary breaking change on IEntityType (#32166)
94bff5a 
Fixes #32105
@ajcvickers ajcvickers added this to the 8.0.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-bug
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @molinch @AndriySvyryd