Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LinqToCSharpSyntaxTranslator more resilient to multiple declaration of the same variable in nested scopes #32716

Closed
roji opened this issue Jan 4, 2024 · 0 comments · Fixed by #32715
Closed

Make LinqToCSharpSyntaxTranslator more resilient to multiple declaration of the same variable in nested scopes #32716

roji opened this issue Jan 4, 2024 · 0 comments · Fixed by #32715
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
9.0.0-preview1

Comments

@roji
Copy link
Member

roji commented Jan 4, 2024 •
edited
Loading

When a LINQ tree with the following shape is given:

{
    var i = 8;
    {
        var i = 9;
    }
}

Although this is legal in LINQ, it isn't in C#, and LinqToCSharpSyntaxTranslator throws a cryptic exception. We should at least throw a more informative exception.
@roji roji mentioned this issue Jan 4, 2024
Open
roji added a commit to roji/efcore that referenced this issue Jan 4, 2024
@roji
informative exception for same ParameterExpression reuse in LinqToCSh…
dd6ed16 
…arpSyntaxTranslator

Fixes dotnet#32716
@roji roji self-assigned this Jan 4, 2024
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 4, 2024
roji added a commit to roji/efcore that referenced this issue Jan 4, 2024
@roji
Informative exception for same ParameterExpression reuse in LinqToCSh…
8898f70 
…arpSyntaxTranslator

Fixes dotnet#32716
@roji roji added this to the 9.0.0 milestone Jan 5, 2024
@roji roji closed this as completed in c5b6b0b Jan 9, 2024
@roji roji linked a pull request Jan 9, 2024 that will close this issue
Fix complex assignment operator handling in LinqToCSharpSyntaxTranslator #32715
Merged
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
9.0.0-preview1
Development

Successfully merging a pull request may close this issue.

Fix complex assignment operator handling in LinqToCSharpSyntaxTranslator roji/efcore
2 participants
@ajcvickers @roji