Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnModelCreating argument #441

Closed
anpete opened this issue Jul 18, 2014 · 0 comments
Closed

OnModelCreating argument #441

anpete opened this issue Jul 18, 2014 · 0 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Milestone
1.0.0

Comments

@anpete
Copy link
Contributor

anpete commented Jul 18, 2014

Should be called "modelBuilder", not "builder".
@anpete anpete self-assigned this Jul 21, 2014
ajcvickers added a commit that referenced this issue Aug 15, 2014
@ajcvickers
Quicker, easier, more seductive... (Change DbContext.OnModelCreating …
a18d0f8 
…to get a ConventionModelBuilder)

The relationship fluent API patterns we have introduced cannot work without some conventions. However, we feel that there is still value in having a ModelBuilder API that is very close to the metadata model and never uses any conventions. Therefore, the plan is to move the new relationship API into the ConventionModelBuilder. Since we want this API to be the one available in OnModelCreating this means that the parameter in OnModelCreating should now be ConventionModelBuilder.

Also did the rename of the parameter per issue #441.
@ajcvickers ajcvickers mentioned this issue Aug 15, 2014
Closed
ajcvickers added a commit that referenced this issue Aug 15, 2014
@ajcvickers
Quicker, easier, more seductive... (Change DbContext.OnModelCreating …
415a8e8 
…to get a ConventionModelBuilder)

The relationship fluent API patterns we have introduced cannot work without some conventions. However, we feel that there is still value in having a ModelBuilder API that is very close to the metadata model and never uses any conventions. Therefore, the plan is to move the new relationship API into the ConventionModelBuilder. Since we want this API to be the one available in OnModelCreating this means that the parameter in OnModelCreating should now be ConventionModelBuilder.

Also did the rename of the parameter per issue #441.
@anpete anpete closed this as completed Aug 20, 2014
@anpete anpete removed their assignment May 6, 2015
@0xced 0xced mentioned this issue Feb 7, 2019
Open
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-alpha3, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@anpete @ajcvickers