Pass enum literals to type mapper for value conversion #11041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpete
approved these changes
Feb 22, 2018
Part of #3620 Also, changed test pattern for BuiltInDataTypes tests to have configuration in the fixture which is used by tests that always run by default. This is consistent with what we do elsewhere and prevents subclasses from forgetting to add a new test method to call the base.
ajcvickers
force-pushed
the
LiterallyLiteral0221
branch
from
df0bc67
to
12e80a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3620
Also, changed test pattern for BuiltInDataTypes tests to have configuration in the fixture which is used by tests that always run by default. This is consistent with what we do elsewhere and prevents subclasses from forgetting to add a new test method to call the base.ls.