Add UDF Db Function tests to EFCore.Relational.Specifications.Tests #12072
Conversation
|
PAUL Thank y’all 🤠 |
pmiddleton
force-pushed
the
udfUnitTest
branch
2 times, most recently
from
73f11ad
to
60b6027
Compare
| @@ -14,608 +12,409 @@ | |||
|
|
|||
| namespace Microsoft.EntityFrameworkCore.Query | |||
| { | |||
| public class UdfDbFunctionOracleTests : IClassFixture<UdfDbFunctionOracleTests.OracleUDFFixture> | |||
| public class UdfDbFunctionOracleTests : UdfDbFunctionTestBase<UdfDbFunctionOracleTests.OracleUDFFixture> | |||
| { | |||
There was a problem hiding this comment.
Casing of OracleUDFFixture. Lets use "Udf" everywhere
|
|
||
| public class Customer | ||
| [Fact] | ||
| public override void Scalar_Function_Extension_Method_Static() |
There was a problem hiding this comment.
Remove redundant overrides.
There was a problem hiding this comment.
Are there no plans to eventually check the Oracle sql?
There was a problem hiding this comment.
No. Unless SQL is drastically different. We do SQL assertion for specific member/method translation which uses different function on server across provider, but if the shape is nearly same then we don't.
There was a problem hiding this comment.
Probably not, unless it is different in some way that is worth verifying - we try to only verify it in one place (when we can).
|
Minor comments and rebase, looks good. |
|
updated and rebased. |
|
Missing testbase override in SQLite functional tests. |
|
@smitpatel SQLite doesn't support these tests. |
|
Then, it needs to be added to exception list. Tests are failing on it. |
|
@pmiddleton Can you add an entry to SqliteComplianceTest.IgnoredTestBases? |
|
@anpete - Thank you. I have been looking for 10 minutes for how that is controlled :) |
|
Thanks @pmiddleton! |
|
@anpete want me to try to implement these tests for Oracle? |
|
@ralmsdeveloper They are there already, right? |
|
@anpete so I figured I'd have some specific test for the provider. |
|
@ralmsdeveloper - I wasn't sure if the CI ran the Oracle tests. I don't have an Oracle instance setup to test on. |
Add UDF Db Function tests to EFCore.Relational.Specifications.Tests per #12044
I don't have a way to test on Oracle. Will the automated tests run on Oracle?