Remove .Wait() calls from query tests #12362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test Windows Release x64 Build please |
Remove unnecessary async keywords Postfix methods returning a Task with "Async" Fixes #5308
maumar
approved these changes
Jun 15, 2018
8 tasks
|
Does this mean that the test suite can be expected to run without any of the deadlocks we had before? I have a special xunit threading attribute because tests would consistently lock up in Appveyor, as threads were stuck synchronously waiting on underlying async operations which could not complete etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary async keywords
Postfix methods returning a Task with "Async"
Fixes #5308