Refactoring query tests so that they are run both synchronously and asynchronously. #12500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // public abstract class AsyncQueryTestBase<TFixture> : IClassFixture<TFixture> | ||
| // where TFixture : class, IQueryFixtureBase, new() | ||
| // { | ||
| // protected AsyncQueryTestBase(TFixture fixture) => Fixture = fixture; |
There was a problem hiding this comment.
// [](start = 0, length = 3)
Remove commented out code
…synchronously. Tests are now Theories, not Facts and take a single parameter bool isAsync. Some tests got converted from sync to async so this will cause compilation errors for the providers who override those tests (e.g. to verify SQL)
|
|
||
| #region AssertAnyWithPredicate | ||
|
|
||
| protected virtual Task AssertAnyWithPredicate<TItem1, TPredicate>( |
There was a problem hiding this comment.
Why not stick to overloads mirroring LINQ? I.e AssertAny instead of AssertAnyWithPredicate
|
This is already merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are now Theories, not Facts and take a single parameter bool isAsync. Some tests got converted from sync to async so this will cause compilation errors for the providers who override those tests (e.g. to verify SQL)