SQLite: Store char as TEXT by default #15044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Mar 15, 2019
| protected override string GenerateNonNullSqlLiteral(object value) | ||
| { | ||
| // NB: We can get Int32 values here too due to compiler-introduced convert nodes | ||
| var charValue = Convert.ToChar(Check.NotNull(value, nameof(value))); |
There was a problem hiding this comment.
At least from Query funcletizer side it should preserve char constant.
There was a problem hiding this comment.
Feel free to remove it as part of the query changes. (Or not since there's no harm in leaving it.) I effectively just moved code that was already in the SQLite provider.
smitpatel
approved these changes
Mar 15, 2019
This was referenced Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes some bugs in the relational char type mapping:
SQLite Migrations: HasComputedColumnSql is ignored #8764Relational: CharTypeMapping doesn't escape apostrophe #11242)Resolves #15020
Providers, the behavior of
CharTypeMappinghas changed in a way that may break derived types.