Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng: Add DatabaseModelFactoryOptions #15090

Merged
merged 5 commits into from
Mar 21, 2019
Merged

RevEng: Add DatabaseModelFactoryOptions #15090

merged 5 commits into from
Mar 21, 2019

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Mar 20, 2019

Resolves #14602

Providers in addition to updating your method signatures, be sure to inherit from DatabaseModelFactory.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This is more for my understanding... Assuming this is meant to allow us to add new scaffolding options without breaking existing providers, providers that haven't been updated to support the new options will simply ignore them, without the user being able to figure out what's going on. Does it make sense to think about some sort of capabilities API which would allow us to generate an error?

@bricelam
Copy link
Contributor Author

providers that haven't been updated to support the new options will simply ignore them

Correct.

some sort of capabilities API which would allow us to generate an error

We can worry about specific flags when add new options, but I wonder if we should add a base DatabaseModelFactory class now (this seems like the best place to add them) or just depend on default interface methods...

Add an abstract base class for IDatabaseModelFactory
@bricelam
Copy link
Contributor Author

(Added an abstract base class.)

@bricelam bricelam merged commit 4958d11 into dotnet:master Mar 21, 2019
@bricelam bricelam deleted the reveng branch March 21, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants