Expose core/relational strings and logging APIs for providers #15091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
bricelam,
smitpatel,
maumar,
roji and
AndriySvyryd
ajcvickers
force-pushed
the
ExceptionMessageReview0320
branch
from
ec038ea
to
8a2f809
Compare
|
Ping for a review on this. I know it's a lot of files, but it's almost all mechanical namespace changes. |
ajcvickers
force-pushed
the
ExceptionMessageReview0320
branch
from
8a2f809
to
2d32855
Compare
Issue #14973 Now public: * CoreLoggerExtensions * RelationalLoggerExtensions * CoreStrings * RelationalStrings * AbstractionsStrings Still internal: * All provider strings and logger extensions * Generated logger definition constructors--providers should access these through the logger extensions Also cleaned up a few provider internal namespace names to be consistent. Also, cleaned up some internal usage in the in-memory provider.
ajcvickers
force-pushed
the
ExceptionMessageReview0320
branch
from
2d32855
to
7648117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #14973
Now public:
Still internal:
Also cleaned up a few provider internal namespace names to be consistent.