Convention set builder refactoring #15168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EFCore/Metadata/Conventions/Internal/IConventionSetCustomizer.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Metadata/Conventions/Internal/IProviderConventionSetBuilder.cs
Outdated
Show resolved
Hide resolved
ajcvickers
force-pushed
the
CrazyTaxi0323
branch
from
e6f1c17
to
3e12029
Compare
src/EFCore/Metadata/Conventions/Infrastructure/IConventionSetCustomizer.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Mar 26, 2019
ajcvickers
force-pushed
the
CrazyTaxi0323
branch
from
3e12029
to
db082a4
Compare
smitpatel
reviewed
Mar 26, 2019
src/EFCore/Metadata/Conventions/Infrastructure/ProviderConventionSetBuilder.cs
Outdated
Show resolved
Hide resolved
ajcvickers
force-pushed
the
CrazyTaxi0323
branch
from
db082a4
to
c501372
Compare
Issue #10672 Now we have: * IProviderConventionSetBuilder -> ProviderConventionSetBuilder -> [RelationalConventionSetBuilder (for relational providers)] -> <MyProviderConventionSetBuilder> * Single registration, scoped service with all the conventions supplied/modified by the provider * IConventionSetCustomizer -> <MyConventionSetCustomizer> * Multiple registration; allows other extensions to customize conventions * Currently used by the proxies package * IConventionSetBuilder -> RuntimeConventionSetBuilder * The combined set of provider conventions with customizations * This is the service that should be resolved to get the current set of conventions being used
ajcvickers
force-pushed
the
CrazyTaxi0323
branch
from
c501372
to
8a87014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10672
Now we have:
IProviderConventionSetBuilder->ProviderConventionSetBuilder->[RelationalConventionSetBuilder (for relational providers)]-><MyProviderConventionSetBuilder>IConventionSetCustomizer-><MyConventionSetCustomizer>IConventionSetBuilder->RuntimeConventionSetBuilder