Remove LazyRef #15434
Merged
Remove LazyRef #15434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #15282
ajcvickers
requested review from
bricelam,
AndriySvyryd and
roji
and removed request for
bricelam,
AndriySvyryd and
roji
| .Select(e => e.ToEntityEntry()).ToList()); | ||
| Entries = entries | ||
| .Where(e => e.EntityState != EntityState.Unchanged) | ||
| .Select(e => e.ToEntityEntry()).ToList(); |
There was a problem hiding this comment.
I think to stop creating EntityEntry instances when they are not needed. But for an exception that seems like overkill.
There was a problem hiding this comment.
Agree, especially if we implement #11256
AndriySvyryd
approved these changes
Apr 21, 2019
ajcvickers
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Apr 21, 2019
Fixes #9172 Needed to stop dotnet/efcore#15434 from breaking ASP.NET Core build.
ajcvickers
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Apr 22, 2019
Fixes #9172 Needed to stop dotnet/efcore#15434 from breaking ASP.NET Core build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15282