Sqlite: Support translation of ToString

[ralmsdeveloper]

• Resolve: Sqlite Support translation of ToString #17223

[smitpatel]

Enable tests

• Like_with_non_string_column_using_ToString
• Convert_ToString

[bricelam]

Also, DateTime, DateTimeOffset, Decimal, Guid, and TimeSpan will be a different format than calling ToString on the client.

[bricelam]

(Well, Guid will be the same format, just upper-case)

[ralmsdeveloper]

Além disso, DateTime, DateTimeOffset, Decimal, Guid e TimeSpan será um formato diferente do que chamar ToString no cliente.

@bricelam

TimeStamp has no difference.
As far as I can see we will have the same information (eval client vs server)

For the others, the translation really is not compatible with client.
_**DateTime, DateTimeOffset, Decimal**_

[ralmsdeveloper]

Habilitar os testes Enable tests

• Like_with_non_string_column_using_ToString
• Convert_ToString

@smitpatel & @bricelam
We don't support Convert.ToString, should we implement?

[bricelam]

We discussed this as a team, and we decided that in EF Core, the semantics of ToString() can be very loose. It can return any reasonable string representation of the value. The format may be different from the string returned by .NET. This is already the case on SQL Server when the client and server are using different cultures.

Given that, everything but ulong should translate using a simple Convert(..., typeof(string)) call on SQLite.

[smitpatel]

We don't support Convert.ToString, should we implement?

Can skip. It can be done in separate PR at later stage.

[smitpatel]

Can we add test for all these types in BuiltInDataTypesTestBase?

It can follow similar structure to QueryBuiltInDataTypesTest,
A client side value converted to ToString compared to ToString on the column.

[smitpatel]

re-assigning this to @maumar

[ralmsdeveloper]

@bricelam sorry for the delay, I had to solve some things here in the company.

I've been doing some testing, so I removed support for:

Guid
Float
Byte[]

For some reason when trying to convert the value (-1.234 float) I'm getting -1.23399996757507

[bricelam]

Add back Guid, float, and byte[].

float is expected to by lossy between .NET and SQLite

[ralmsdeveloper]

@bricelam I'm sorry for the delay, I had a lot of things to solve here at the company, I'll add that until Saturday.

[bricelam]

No rush; we don't RTM until November 😉

[ajcvickers]

This PR still needs work and is lower priority than other items we need to complete for 5.0, so unfortunately we are going to hold off on this for now.

[smitpatel]

@ralmsdeveloper - Are you planning to complete this? Else I can take over and make needed changes to merge it to main.

[smitpatel]

@ralmsdeveloper - Thank you.

[ralmsdeveloper]

@smitpatel sorry for the delay, I took a few days to help my father with his health!

Thanks!