Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0-preview2] Update hosted and BYOC agents used in our builds #20215

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Mar 7, 2020

  • dotnet/aspnetcore-internal#3540
  • nit: Consistently use in / notin with Build.Reason
    • YAML was inconsistent and this aligns w/ the Arcade code

- dotnet/aspnetcore-internal#3540
- nit: Consistently use `in` / `notin` with `Build.Reason`
  - YAML was inconsistent and this aligns w/ the Arcade code
@dougbu
Copy link
Member Author

dougbu commented Mar 7, 2020

@Pilchie the most important part of this (given the March 23 deadline) is the macOS switch. Any objection to the rest (faster queues and nits) in a tell-mode fix?

@dougbu
Copy link
Member Author

dougbu commented Mar 7, 2020

NO-MERGE because I'm waiting for @Pilchie regardless of other reviewers. But @dotnet/aspnet-build please do review!

@Pilchie
Copy link
Member

Pilchie commented Mar 9, 2020

Looks fine to me, but has conflicts?

Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I don't see conflicts.

@dougbu
Copy link
Member Author

dougbu commented Mar 9, 2020

Un * No merge *ing

@dougbu dougbu merged commit b424608 into release/5.0-preview2 Mar 9, 2020
@dougbu dougbu deleted the dougbu/5.0-preview2/newer.agents.3540 branch March 9, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants