Fix for issue #1954 - not throwing on duplicate property #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -77,7 +71,13 @@ private EntityType(object typeOrName, Model model) | |||
|
|
|||
| Model = model; | |||
|
|
|||
| _foreignKeys = new SortedDictionary<IReadOnlyList<Property>, ForeignKey>(PropertyListComparer.Instance); | |||
There was a problem hiding this comment.
Did anything change here? Why have these been moved?
|
Can you describe the change a little more? In particular, the "reference based propagation" approach. |
mikary
force-pushed
the
recursivePropertyCollision
branch
from
8fb4064
to
386a9a2
Compare
|
Updated based on feedback |
mikary
force-pushed
the
recursivePropertyCollision
branch
from
386a9a2
to
22a4b39
Compare
| @@ -37,9 +37,11 @@ public class EntityType : Annotatable, IEntityType | |||
| private Key _primaryKey; | |||
| private EntityType _baseType; | |||
|
|
|||
| public event EventHandler<Property> PropertyMetadataChanged; | |||
| private IEnumerable<EntityType> DerivedTypes => Model.EntityTypes.Where(t => t.BaseType == this); | |||
There was a problem hiding this comment.
Make this a method and rename to something like GetDirectDescendents
mikary
force-pushed
the
recursivePropertyCollision
branch
from
22a4b39
to
49373ae
Compare
|
Not sure if there is anything outstanding here...
|
if not.
mikary
force-pushed
the
recursivePropertyCollision
branch
from
49373ae
to
50cfff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1954
Switching from event based to reference based propagation of property metadata changes to allow for full traversals when adding a base type to an existing tree.
@ajcvickers @anpete