Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite Migrations: Rebuild tables #21575

Merged
merged 1 commit into from
Jul 16, 2020
Merged

SQLite Migrations: Rebuild tables #21575

merged 1 commit into from
Jul 16, 2020

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jul 9, 2020

More tests to come, but I think we can get something merged and iterate on it.

Fixes #329

@bricelam bricelam requested a review from a team July 9, 2020 23:42
@roji

This comment has been minimized.

@bricelam bricelam requested a review from a team July 15, 2020 00:26
@bricelam
Copy link
Contributor Author

bricelam commented Jul 15, 2020

Design meeting notes:

  • We don't need to warn that we're doing a table rebuild because they're so pervasive on SQLite that it would just become noise
    • But we should definitely consider warning if we do this on other providers
  • Verify what happens with self-referencing foreign key constraints
  • We only need to create indexes before the INSERT if they're new
    • Existing UNIQUE indexes already ensure that the data is valid
    • We can create them under their actual name since they won't conflict

@bricelam bricelam changed the base branch from master to release/5.0-preview8 July 16, 2020 15:11
More tests to come, but I think we can get something merged and iterate on it.

Fixes #329
@bricelam bricelam merged commit c97657e into dotnet:release/5.0-preview8 Jul 16, 2020
@bricelam bricelam deleted the rebuild branch July 16, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlite Migrations: Table rebuilds
4 participants