3.1.x: Disable NRTs in scaffolding (replaced) #23053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
changed the title
bricelam
approved these changes
Oct 20, 2020
|
Any idea how to restart the weirdly-cancelled Helix build? I'm not finding a re-run button :/ |
roji
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
You are out of luck unless you create a new PR |
roji
force-pushed
the
ScaffoldingDisableNullable5.0
branch
from
8092023
to
265bfb2
Compare
|
😢 Replaced by #23060 |
roji
changed the title
This was
unlinked from
issues
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR merged for 5.0: #21190
This backports the fix for #23016 to 3.1.
Description
This adds
#nullable disableat the top of all C# files generated by EF Core's scaffolding.Customer Impact
EF Core scaffolding is currently unaware of C# 8.0 Nullable Reference Types (NRT), and generates a code model without annotations. If the project has NRTs turned on, the model get incorrectly interpreted, i.e. nullable database text columns are represented by
string SomeProperty, which with NRTs is interpreted as non-nullable.How found
Reported by users (e.g. #23016). The issue for adding fully supporting NRTs, i.e. correctly scaffolding code with annotations (#15520) also has 28 votes, giving reason to believe many users are running into this.
Test coverage
This PR includes testing that the
#nullable disableactually gets scaffolded.Regression?
No.
Risk
Low. This touches scaffolding code only - which does not affect EF Core runtime behavior - and in a minor way.