Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TPC support for data seeding #27903

Merged
merged 3 commits into from Apr 29, 2022
Merged

Add TPC support for data seeding #27903

merged 3 commits into from Apr 29, 2022

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Apr 28, 2022

Use row-based diffing for data seeding

Part of #3170
Fixes #22063
Fixes #12466
Fixes #27575

Use row-based diffing for data seeding

Fixes #22063
Fixes #12466
Fixes #27575
@AndriySvyryd AndriySvyryd requested a review from a team April 28, 2022 07:22
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 🇮🇹

If anyone else is more proficient in this area it would be good to get another review, otherwise here are some nits :)

Comment on lines +49 to +53
var providerType = Converter?.ProviderClrType ?? ClrType;
if (providerType.IsAssignableTo(typeof(TGeometry)))
{
ProviderValueComparer = (ValueComparer)Activator.CreateInstance(typeof(GeometryValueComparer<>).MakeGenericType(providerType))!;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bricelam FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants