Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Remove the requirement that instance or first argument would be enumerable in aggregate function #28099

Merged
1 commit merged into from
May 25, 2022
Merged

Query: Remove the requirement that instance or first argument would be enumerable in aggregate function #28099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,8 +943,7 @@ protected override Expression VisitMethodCall(MethodCallExpression methodCallExp
{
var argument = arguments[i];
var visitedArgument = Visit(argument);
if (i == 0
&& visitedArgument is EnumerableExpression)
if (visitedArgument is EnumerableExpression)
{
if (enumerableExpression != null)
{
Expand Down
6 changes: 2 additions & 4 deletions src/EFCore/Query/ICompiledQueryCacheKeyGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@ namespace Microsoft.EntityFrameworkCore.Query;

/// <summary>
/// <para>
/// Creates keys that uniquely identifies a query. This is used to store and lookup
/// compiled versions of a query in a cache.
/// Creates keys that uniquely identifies a query. This is used to store and lookup compiled versions of a query in a cache.
/// </para>
/// <para>
/// This type is typically used by database providers (and other extensions). It is generally
/// not used in application code.
/// This type is typically used by database providers (and other extensions). It is generally not used in application code.
/// </para>
/// </summary>
/// <remarks>
Expand Down