SQLite type mapping should not be returned without converter when CLR type does not match #29633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type does not match Fixes #29521
ajcvickers
commented
Nov 21, 2022
| [InlineData("REDOUBLES", typeof(double), DbType.Double)] | ||
| [InlineData("OBJECT", typeof(byte[]), DbType.Binary)] | ||
| [InlineData("DISCOMBOBULATED", typeof(byte[]), DbType.Binary)] | ||
| public void Does_mappings_for_store_type(string storeType, Type clrType, DbType? dbType) |
There was a problem hiding this comment.
That we match types like this in SQLite is very strange. But at this point I don't think we should break it.
AndriySvyryd
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29521