Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to #28648 - Json/Query: translate element access of a json array #29656

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix to #28648 - Json/Query: translate element access of a json array #29656

merged 1 commit into from
Dec 5, 2022

Commits on Dec 5, 2022

  1. Fix to #28648 - Json/Query: translate element access of a json array 

    Converting indexer over list/array into ElementAt, so that nav expansion understands it and can perform pushown and inject MaterializeCollectionNavigation expression where necessary.
In translation phase (specifically in ExpandSharedTypeEntities) we recognize the pattern that nav expansion creates and if the root is JsonQueryExpression, we apply collection index over it.
JsonQueryExpression path segment now consists of two components - string representing JSON property name and SqlExpression representing collection index (it can be constant, parameter or any arbitrary expression that resolves to int)

Deduplication is heavily restricted currently - we only de-duplicate projections whose additional path consists of JSON property accesses only (no collection indexes allowed).
All queries projecting entities that need JSON array access must be set to NoTracking (for now). This is because we don't flow those collection index values into shaper. Instead, the ordinal keys are filled with dummy values, which prohibits us from doing proper change tracking.

Fixes #28648
    @maumar
    maumar committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    94be38c View commit details
    Browse the repository at this point in the history