[release/7.0] Fix bug where a non-sproc command comes before a sproc command #29722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#29680) Fixes dotnet#29643 (cherry picked from commit 35e9e5a)
roji
changed the title
AndriySvyryd
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29643, #29680
Description
In the new stored procedure mapping support, the logic to count parameters for the purpose of propagating sproc output variables incorrectly assumed all commands in the batch use a sproc. This causes us to propagate the wrong database-generated value into the wrong entity property.
Customer impact
When mixing both stored procedure and non-stored procedure updates in the same SaveChanges batch, database-generated values may cause an exception, or even get assigned to the wrong entity property (bad data).
How found
Customer reported on 7.0
Regression
No.
Testing
Added a test for the affected scenario.
Risk
Low; the fix is quite trivial, and a quirk was added to revert back to older behavior.