Reset query tracking behavior correctly if set on DbContextOptions #29766
Conversation
| @@ -882,8 +882,12 @@ private void SetLeaseInternal(DbContextLease lease) | |||
| || _configurationSnapshot.HasChangeTrackerConfiguration) | |||
| { | |||
| var changeTracker = ChangeTracker; | |||
| ((IResettableService)changeTracker).ResetState(); | |||
There was a problem hiding this comment.
So we're calling ResetState here just in order to set _queryTrackingBehavior back to _defaultQueryTrackingBehavior, in case we don't need to set it here again? Because it also sets all the other stuff that we'll just overwrite here below. Any way for us to just capture the default in the configuration snapshot so we can always just write it?
There was a problem hiding this comment.
I tried that first, but it gets complicated because at the time we create the snapshot we don't necessarily have services available to find the default, and likewise, the ChangeTracker itself may not be available. So things broke.
There was a problem hiding this comment.
OK, I just get sad when we add more stuff to the context resetting...
| @@ -882,8 +882,12 @@ private void SetLeaseInternal(DbContextLease lease) | |||
| || _configurationSnapshot.HasChangeTrackerConfiguration) | |||
| { | |||
| var changeTracker = ChangeTracker; | |||
| ((IResettableService)changeTracker).ResetState(); | |||
There was a problem hiding this comment.
OK, I just get sad when we add more stuff to the context resetting...
|
@roji We could adds new API here to avoid setting stuff twice. Did not seem worth the extra complexity to me. @AndriySvyryd? (Also, we're probably going to patch this, so wanted to keep it simple for that reason.) |
|
We could benchmark the impact of the resetting code. Intuitively, it doesn't seem to add a significant amount of work. |
Fixes #29733