Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Include table name for overrides in snapshot. #29820

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

AndriySvyryd
Copy link
Member

This is a port of #29819
Fixes #29534

Description

The model snapshot generated for a migration that includes types in a TPH hierarchy with table-specific configuration doesn't include the table name for derived classes.

Customer impact

The generated migration will not compile until the customer fixes it manually.

How found

Multiple customer reports on 7.0

Regression

Yes.

Testing

Added tests for the affected scenario

Risk

Low; the fix only impacts design-time tooling.

@AndriySvyryd AndriySvyryd changed the base branch from main to release/7.0 December 9, 2022 23:01
@wtgodbe wtgodbe merged commit 2668bc6 into release/7.0 Jan 4, 2023
@wtgodbe wtgodbe deleted the Issue29534_7.0 branch January 4, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated Model Snapshot throws InvalidOperationException
4 participants