Add static Print methods to ExpressionPrinter #29854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And some cleanup Closes dotnet#29851
roji
commented
Dec 14, 2022
| @@ -386,7 +393,7 @@ protected override Expression VisitBlock(BlockExpression blockExpression) | |||
| } | |||
| } | |||
|
|
|||
| var expressions = blockExpression.Result != null | |||
| var expressions = blockExpression.Expressions.Count > 0 | |||
There was a problem hiding this comment.
BlockExpression.Result is non-nullable, but does through for empty blocks (so this was a bug).
| Expression expression, | ||
| int? characterLimit = null) | ||
| => PrintCore(expression, characterLimit, verbose: false); | ||
| public virtual string PrintExpression(Expression expression, int? characterLimit = null) |
There was a problem hiding this comment.
C# doesn't allow static/non-static overloading where the signature is otherwise the same. Since the static API is what we're likely to use in debugging (where shorter names are the most important), I'm proposing to have a static Print, and a longer non-static PrintExpression (which we'd use only in code).
This was referenced Dec 14, 2022
maumar
approved these changes
Dec 14, 2022
roji
added a commit
to roji/efcore
that referenced
this pull request
Jan 10, 2023
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some cleanup
Closes #29851