[release/7.0] Prevent re-entrance into DetectChanges #30240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #30204
Fixes #30122
Fixes #30135
Description
EF7 contains some new calls to local
DetectChanges. This resulted in re-entrance intoDetectChangesfor some types of graphs. This change prevents that.Customer impact
So far two different reported issues where the re-entrance caused incorrect behavior, and we expect more cases of exceptions or incorrect state depending on the shape and state of graphs being traversed.
How found
Multiple customer reports on 7.0.
Regression
Yes.
Testing
New tests added for the reported graphs and similar cases.
Risk
Low; flag to prevent re-entrance, does not need to be thread-safe, and a quirk was added to revert back to older behavior.