[release/7.0] Store null table name in the model snapshot for TPC abstract types #30275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Feb 14, 2023
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #30257
Fixes #30058
Description
TPC mapping, new in EF7, has no table mapping for abstract base types. However, this was not being stored in the model snapshot for non-root abstract types, causing repeated erroneous generation of a migration to drop the table.
Customer impact
Repeated, incorrect code to drop a non-existent table on every migration generated. No reasonable workaround.
How found
Customer reported on 7.0.
Regression
No; bug in new feature of EF7.
Testing
New test added for a model snapshot with this kind of model.
Risk
Low; very simple change. And quirked, since that's what we do. :-)